Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

recurse on Proxy objects #575

Merged
merged 10 commits into from
Jul 31, 2018
Merged

recurse on Proxy objects #575

merged 10 commits into from
Jul 31, 2018

Conversation

ajtritt
Copy link
Member

@ajtritt ajtritt commented Jul 30, 2018

Motivation

Link resolution on read was breaking. This was exposed by using the same ElectrodeTableRegion in multiple places. The bug was presenting itself with the following error:

AttributeError: 'Proxy' object has no attribute 'name'

Fix #558
Fix #568

@ajtritt ajtritt requested a review from bendichter July 30, 2018 20:04
bendichter
bendichter previously approved these changes Jul 30, 2018
Copy link
Contributor

@bendichter bendichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I tested this on both cases and confirms that it works. Also thanks for adding comments!

@codecov
Copy link

codecov bot commented Jul 30, 2018

Codecov Report

Merging #575 into dev will increase coverage by 2.37%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev     #575      +/-   ##
=========================================
+ Coverage   74.4%   76.77%   +2.37%     
=========================================
  Files         59       59              
  Lines       6334     6335       +1     
  Branches    1252     1253       +1     
=========================================
+ Hits        4713     4864     +151     
+ Misses      1268     1137     -131     
+ Partials     353      334      -19
Impacted Files Coverage Δ
src/pynwb/form/build/map.py 79.08% <100%> (+5.83%) ⬆️
src/pynwb/form/utils.py 88.42% <0%> (-0.36%) ⬇️
src/pynwb/core.py 72.4% <0%> (+0.2%) ⬆️
src/pynwb/form/spec/spec.py 80.26% <0%> (+0.29%) ⬆️
src/pynwb/form/container.py 84.48% <0%> (+1.72%) ⬆️
src/pynwb/base.py 97.87% <0%> (+2.12%) ⬆️
src/pynwb/form/build/builders.py 90.4% <0%> (+2.8%) ⬆️
src/pynwb/file.py 91.04% <0%> (+2.98%) ⬆️
src/pynwb/form/backends/hdf5/h5tools.py 74.91% <0%> (+9.16%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 432699f...3b70c95. Read the comment docs.

@bendichter bendichter merged commit 44b6950 into dev Jul 31, 2018
@ajtritt ajtritt deleted the bug/recurse_proxy branch August 6, 2018 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants