-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
recurse on Proxy objects #575
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks! I tested this on both cases and confirms that it works. Also thanks for adding comments!
Codecov Report
@@ Coverage Diff @@
## dev #575 +/- ##
=========================================
+ Coverage 74.4% 76.77% +2.37%
=========================================
Files 59 59
Lines 6334 6335 +1
Branches 1252 1253 +1
=========================================
+ Hits 4713 4864 +151
+ Misses 1268 1137 -131
+ Partials 353 334 -19
Continue to review full report at Codecov.
|
Motivation
Link resolution on read was breaking. This was exposed by using the same ElectrodeTableRegion in multiple places. The bug was presenting itself with the following error:
Fix #558
Fix #568