Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose AWS Region to NWBHDF5IO #1903

Merged
merged 4 commits into from
May 22, 2024
Merged

Expose AWS Region to NWBHDF5IO #1903

merged 4 commits into from
May 22, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented May 17, 2024

Motivation

Companion to hdmf-dev/hdmf#1040 to allow the user to set the AWS region in NWBHDF5IO. Requires that branch of HDMF to be merged and released.

Also use HDMF 3.14.0

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (7a0d8b4) to head (9dc816a).
Report is 20 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1903   +/-   ##
=======================================
  Coverage   92.02%   92.02%           
=======================================
  Files          27       27           
  Lines        2620     2620           
  Branches      685      685           
=======================================
  Hits         2411     2411           
  Misses        139      139           
  Partials       70       70           
Flag Coverage Δ
integration 73.24% <100.00%> (ø)
unit 83.93% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly marked this pull request as ready for review May 22, 2024 18:14
@rly rly requested a review from mavaylon1 May 22, 2024 18:14
@rly
Copy link
Contributor Author

rly commented May 22, 2024

Tests are failing due to unrelated issues with the Zarr tutorial.

@rly rly merged commit c7ff5ef into dev May 22, 2024
20 of 24 checks passed
@rly rly deleted the expose_aws_region branch May 22, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants