Validator function call bug fixes #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #187 +/- ##
=======================================
Coverage 57.69% 57.69%
=======================================
Files 43 43
Lines 4749 4749
=======================================
Hits 2740 2740
Misses 2009 2009
Continue to review full report at Codecov.
|
jcfr
reviewed
Nov 7, 2017
| @@ -33,22 +33,22 @@ def print_errors(errors): | |||
| args = parser.parse_args() | |||
|
|
|||
| if not os.path.exists(args.path): | |||
| write('%s not found' % path, file=sys.stderr) | |||
| write_out('%s not found' % path, file=sys.stderr) | |||
There was a problem hiding this comment.
path -> args.path
No action required. I rebased the topic and will update it shortly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated validator to use get_manager() instead of get_build_manager() and write_out() instead of write()