Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading file with linked TimeSeriesReferenceVectorData #1865

Merged
merged 4 commits into from
Mar 22, 2024

Conversation

rly
Copy link
Contributor

@rly rly commented Mar 22, 2024

Motivation

Fix #1863.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from oruebel March 22, 2024 06:28
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.96%. Comparing base (751983b) to head (c09c27e).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1865   +/-   ##
=======================================
  Coverage   91.95%   91.96%           
=======================================
  Files          27       27           
  Lines        2661     2663    +2     
  Branches      699      700    +1     
=======================================
+ Hits         2447     2449    +2     
  Misses        142      142           
  Partials       72       72           
Flag Coverage Δ
integration 72.36% <100.00%> (+1.56%) ⬆️
unit 84.07% <33.33%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly rly enabled auto-merge (squash) March 22, 2024 19:36
@rly rly merged commit 8b42af3 into dev Mar 22, 2024
22 of 23 checks passed
@rly rly deleted the fix/linked_timeseries_col branch March 22, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Exception reading linked NWBFile with TimeSeriesReference in NWBFile.trials
2 participants