Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix importlib_metadata incompatibility #1694

Merged
merged 2 commits into from
May 16, 2023
Merged

Fix importlib_metadata incompatibility #1694

merged 2 commits into from
May 16, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented May 16, 2023

Motivation

Gallery tests are failing because pip install requirements-doc.txt after installing the latest hdmf results in an incompatibility in the requirements for python 3.7. This PR fixes it.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #1694 (372dc37) into dev (2eb2ddf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1694   +/-   ##
=======================================
  Coverage   91.93%   91.93%           
=======================================
  Files          26       26           
  Lines        2592     2592           
  Branches      679      679           
=======================================
  Hits         2383     2383           
  Misses        134      134           
  Partials       75       75           
Flag Coverage Δ
integration 71.52% <ø> (ø)
unit 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rly rly requested a review from oruebel May 16, 2023 03:33
@oruebel oruebel merged commit 89d9e04 into dev May 16, 2023
@oruebel oruebel deleted the fix/req_incompatibility branch May 16, 2023 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants