Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testing for python 3.11, update reqs #1687

Merged
merged 6 commits into from
Apr 12, 2023
Merged

Add testing for python 3.11, update reqs #1687

merged 6 commits into from
Apr 12, 2023

Conversation

rly
Copy link
Contributor

@rly rly commented Apr 12, 2023

Motivation

requirements.txt had set the h5py version to 3.7.0 which needs to be built for python 3.11. This can cause issues in CI and local builds. So, we update the requirements.txt to use h5py 3.8.0 and in the process also add support for Python 3.11.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly
Copy link
Contributor Author

rly commented Apr 12, 2023

  • Update branch protection after merge

@rly rly added category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users labels Apr 12, 2023
@codecov
Copy link

codecov bot commented Apr 12, 2023

Codecov Report

Merging #1687 (7ea13b7) into dev (de7f474) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##              dev    #1687    +/-   ##
========================================
  Coverage   91.93%   91.93%            
========================================
  Files          26       26            
  Lines        2592     2592            
  Branches      477      679   +202     
========================================
  Hits         2383     2383            
  Misses        134      134            
  Partials       75       75            
Flag Coverage Δ
integration 71.52% <ø> (ø)
unit 83.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rly rly merged commit 1d1d142 into dev Apr 12, 2023
@rly rly deleted the support_py311 branch April 12, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: enhancement improvements of code or code behavior priority: medium non-critical problem and/or affecting only a small set of NWB users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants