Skip to content

Patch clamp series data shape #1596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 3, 2022
Merged

Patch clamp series data shape #1596

merged 4 commits into from
Dec 3, 2022

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Nov 12, 2022

Motivation

fix #1300

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@bendichter bendichter requested a review from rly November 12, 2022 16:13
@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #1596 (bb0203f) into dev (a1af42d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1596   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files          25       25           
  Lines        2510     2510           
  Branches      474      474           
=======================================
  Hits         2289     2289           
  Misses        140      140           
  Partials       81       81           
Flag Coverage Δ
integration 70.35% <100.00%> (ø)
unit 84.42% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pynwb/icephys.py 91.96% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bendichter bendichter requested a review from oruebel December 2, 2022 23:02
@oruebel oruebel merged commit 31b887d into dev Dec 3, 2022
@oruebel oruebel deleted the patch_clamp_series_data_shape branch December 3, 2022 18:50
apdavison added a commit to apdavison/python-neo that referenced this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PatchClampSeries.data should be 1-dimensional
2 participants