Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mock icephys and tests #1595

Merged
merged 3 commits into from
Dec 4, 2022
Merged

add mock icephys and tests #1595

merged 3 commits into from
Dec 4, 2022

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Nov 12, 2022

How to test the behavior?

from pynwb.testing.mock.icephys import mock_VoltageClampSeries

mock_VoltageClampSeries()

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Nov 12, 2022

Codecov Report

Merging #1595 (6c33889) into dev (31b887d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1595   +/-   ##
=======================================
  Coverage   91.19%   91.19%           
=======================================
  Files          25       25           
  Lines        2510     2510           
  Branches      474      474           
=======================================
  Hits         2289     2289           
  Misses        140      140           
  Partials       81       81           
Flag Coverage Δ
integration 70.35% <ø> (ø)
unit 84.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bendichter bendichter requested a review from oruebel November 12, 2022 16:42
conversion=1.0,
timestamps=None,
starting_time=None,
rate=100_000.,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not know this was a thing in Python!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty cool, huh?

@bendichter bendichter merged commit f01dabf into dev Dec 4, 2022
@rly rly deleted the add_mock_icephys branch December 22, 2023 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants