Adding OnePhotonSeries class

[CodyCBakerPhD]

Motivation

Adding the OnePhotonSeries class to PyNWB, which was recently added to the schema in NeurodataWithoutBorders/nwb-schema#523

[codecov]

Codecov Report

Merging #1593 (daa13f1) into dev (f4bd3bc) will increase coverage by 0.53%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1593      +/-   ##
==========================================
+ Coverage   91.25%   91.78%   +0.53%     
==========================================
  Files          25       26       +1     
  Lines        2515     2557      +42     
  Branches      477      489      +12     
==========================================
+ Hits         2295     2347      +52     
+ Misses        139      134       -5     
+ Partials       81       76       -5     

Flag	Coverage Δ
integration	71.17% <91.11%> (+0.95%)	⬆️
unit	83.92% <53.33%> (-0.57%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/pynwb/file.py	88.08% <100.00%> (+0.08%)	⬆️
src/pynwb/io/file.py	97.07% <100.00%> (+2.73%)	⬆️
src/pynwb/io/utils.py	100.00% <100.00%> (ø)
src/pynwb/ophys.py	96.05% <100.00%> (+0.40%)	⬆️
src/pynwb/io/base.py	91.35% <0.00%> (+7.40%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[CodyCBakerPhD]

@rly Looks like when I updated the nwb-schema version, it triggered some failing container-type tests? Any ideas?

[CodyCBakerPhD]

@rly @oruebel @bendichter OK with #1540 in this now appears to be working, ready for review

[oruebel]

This looks in general good to me. Could you also add:

• A mock_OnePhotonSeries function to the mock test module src/pynwb/testing/mock/ophys.py Here the example for TwoPhotonSeries:
  

  pynwb/src/pynwb/testing/mock/ophys.py

  Line 66 in 5d8efdb

  def mock_TwoPhotonSeries(

• A roundtrip test for One`PhotonSeries to tests/integration/hdf5/test_ophys.py. Here the test for TwoPhotonSeries:
  

  pynwb/tests/integration/hdf5/test_ophys.py

  Line 138 in 5d8efdb

  class TestTwoPhotonSeriesIO(AcquisitionH5IOMixin, TestCase):

[CodyCBakerPhD]

@oruebel Adding the round-trip IO integration test indeed reveals an issue with one of the new fields - the relevant piece of the traceback is

 hdmf.build.errors.ConstructError: ..... 

Could not construct OnePhotonSeries object due to: OnePhotonSeries.__init__: incorrect type for 'binning' (
    got 'uint64', expected 'int'
)

any suggestions for how to fix this?

[CodyCBakerPhD]

In particular, the schema specification for this field is actually as uint8: https://github.com/NeurodataWithoutBorders/nwb-schema/blob/dev/core/nwb.ophys.yaml#L21

[oruebel]

WooHoo 100% test coverage on the diff. Thanks @CodyCBakerPhD for adding support for OnePhotonSeries!

@rly since this PR updates the schema, does this need to be merged with the dev branch or a different release branch?

[rly]

This should go to a new branch for schema 2.6 support. So that we try to stick with the release schedule, NWB 2.6 will be released around Jan. 5 and the corresponding PyNWB and MatNWB releases should be made around Jan. 8.

[rly]

I'll create that new branch and redirect this PR there.

[rly]

This is now good to merge @CodyCBakerPhD