Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better error message for common git clone error #1591

Merged
merged 8 commits into from
Nov 10, 2022
Merged

Conversation

bendichter
Copy link
Contributor

@bendichter bendichter commented Nov 10, 2022

Motivation

fix #1564

fix #1563

How to test the behavior?

I am not sure how to test this properly.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Nov 10, 2022

Codecov Report

Merging #1591 (95f247d) into dev (a4ef56f) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              dev    #1591      +/-   ##
==========================================
- Coverage   91.34%   91.30%   -0.04%     
==========================================
  Files          25       25              
  Lines        2507     2508       +1     
  Branches      471      471              
==========================================
  Hits         2290     2290              
- Misses        137      138       +1     
  Partials       80       80              
Flag Coverage Δ
integration 70.53% <0.00%> (-0.03%) ⬇️
unit 84.40% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pynwb/__init__.py 75.57% <0.00%> (-0.59%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bendichter
Copy link
Contributor Author

@rly any idea why the codecov is failing?

@rly
Copy link
Contributor

rly commented Nov 10, 2022

Sometimes codecov has a connection error, or I think when we do a bunch of commits in quick succession and some actions get canceled, the coverage uploader gets confused. So I just re-run the jobs.

@rly rly merged commit d435aa6 into dev Nov 10, 2022
@rly rly deleted the core_not_in_namespace branch November 10, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: better error message when you don't recurse submodules [Bug]: 'Core' not a namespace
2 participants