Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme fix #1573

Merged
merged 4 commits into from
Oct 20, 2022
Merged

Readme fix #1573

merged 4 commits into from
Oct 20, 2022

Conversation

mavaylon1
Copy link
Collaborator

Motivation

What was the reasoning behind this change? Please explain the changes briefly.

How to test the behavior?

Show how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@mavaylon1 mavaylon1 requested a review from rly October 20, 2022 00:22
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #1573 (124ff66) into dev (b0b6f3d) will decrease coverage by 6.90%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              dev    #1573      +/-   ##
==========================================
- Coverage   91.34%   84.44%   -6.91%     
==========================================
  Files          25       25              
  Lines        2507     2507              
  Branches      471      471              
==========================================
- Hits         2290     2117     -173     
- Misses        137      307     +170     
- Partials       80       83       +3     
Flag Coverage Δ
integration ?
unit 84.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pynwb/validate.py 26.04% <0.00%> (-73.96%) ⬇️
src/pynwb/io/ophys.py 45.45% <0.00%> (-54.55%) ⬇️
src/pynwb/io/misc.py 39.47% <0.00%> (-47.37%) ⬇️
src/pynwb/io/image.py 66.66% <0.00%> (-33.34%) ⬇️
src/pynwb/io/base.py 58.62% <0.00%> (-26.44%) ⬇️
src/pynwb/io/core.py 61.11% <0.00%> (-18.52%) ⬇️
src/pynwb/io/file.py 82.38% <0.00%> (-11.95%) ⬇️
src/pynwb/misc.py 87.59% <0.00%> (-3.65%) ⬇️
src/pynwb/icephys.py 89.71% <0.00%> (-2.26%) ⬇️
src/pynwb/ophys.py 94.20% <0.00%> (-1.45%) ⬇️
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mavaylon1 mavaylon1 merged commit e35690f into dev Oct 20, 2022
@mavaylon1 mavaylon1 deleted the readme_fix branch October 20, 2022 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants