Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete test files generated from running sphinx gallery examples #1517

Merged
merged 11 commits into from
Aug 14, 2022

Conversation

rly
Copy link
Contributor

@rly rly commented Jul 21, 2022

Motivation

Running the Sphinx gallery examples locally (python test.py -e) generates a lot of test files that are frustrating to delete. This PR deletes the resulting test files after running those examples in the test suite. In order to delete the test files on Windows, the h5py file handle must be explicitly closed, so this PR also updates the Sphinx gallery examples to close the file.

How to test the behavior?

python test.py -e

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from oruebel July 21, 2022 15:45
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1517 (4becdcf) into dev (90c6bd8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1517   +/-   ##
=======================================
  Coverage   90.65%   90.65%           
=======================================
  Files          25       25           
  Lines        2494     2494           
  Branches      466      466           
=======================================
  Hits         2261     2261           
  Misses        148      148           
  Partials       85       85           
Flag Coverage Δ
integration 69.60% <ø> (ø)
unit 84.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from updating the instructions for creating tutorials this looks good to me.

@rly rly requested a review from oruebel August 12, 2022 21:28
oruebel
oruebel previously approved these changes Aug 12, 2022
@rly
Copy link
Contributor Author

rly commented Aug 12, 2022

Code coverage for the validation script was not being maintained and uploaded to codecov. I fixed that. Please re-approve

@rly rly requested a review from oruebel August 12, 2022 22:45
@oruebel
Copy link
Contributor

oruebel commented Aug 13, 2022

Looks good. Thanks for addressing this issue.

@rly rly merged commit 89d1c1b into dev Aug 14, 2022
@rly rly deleted the remove_gallery_test_files branch August 14, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants