-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete test files generated from running sphinx gallery examples #1517
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1517 +/- ##
=======================================
Coverage 90.65% 90.65%
=======================================
Files 25 25
Lines 2494 2494
Branches 466 466
=======================================
Hits 2261 2261
Misses 148 148
Partials 85 85
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from updating the instructions for creating tutorials this looks good to me.
Code coverage for the validation script was not being maintained and uploaded to codecov. I fixed that. Please re-approve |
Looks good. Thanks for addressing this issue. |
Motivation
Running the Sphinx gallery examples locally (
python test.py -e
) generates a lot of test files that are frustrating to delete. This PR deletes the resulting test files after running those examples in the test suite. In order to delete the test files on Windows, the h5py file handle must be explicitly closed, so this PR also updates the Sphinx gallery examples to close the file.How to test the behavior?
Checklist
flake8
from the source directory.