Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpikeEventSeries: add test for timestamp check #1507

Merged
merged 6 commits into from
Dec 5, 2022
Merged

Conversation

bendichter
Copy link
Contributor

No description provided.

@bendichter bendichter requested a review from rly July 14, 2022 21:10
@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #1507 (d7ac9b1) into dev (f01dabf) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1507      +/-   ##
==========================================
+ Coverage   91.19%   91.27%   +0.07%     
==========================================
  Files          25       25              
  Lines        2510     2510              
  Branches      474      474              
==========================================
+ Hits         2289     2291       +2     
+ Misses        140      139       -1     
+ Partials       81       80       -1     
Flag Coverage Δ
integration 70.35% <0.00%> (ø)
unit 84.50% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pynwb/ecephys.py 97.29% <100.00%> (+1.80%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

rly
rly previously approved these changes Jul 14, 2022
rly
rly previously approved these changes Jul 14, 2022
rly
rly previously approved these changes Dec 4, 2022
@rly
Copy link
Contributor

rly commented Dec 4, 2022

This was amusing: one test tested that ElectrodeGroup(...) would raise a TypeError, but the code in ElectrodeGroup.__init__ generated a ValueError. That's odd. And the test passed! Why? A TypeError was raised because of an error in the code that created the ValueError. So fixing the test to catch a ValueError made the test fail until I also fixed the code that created the ValueError.

if args_to_set['position'] and len(args_to_set['position']) != 3:
>           raise ValueError('ElectrodeGroup position argument must have three elements: x, y, z, but received: %s'
                             % args_to_set['position'])
E           TypeError: not all arguments converted during string formatting

@rly rly merged commit 03740d0 into dev Dec 5, 2022
@rly rly deleted the test_timestamp_agreement branch December 5, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants