Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RoiResponseSeries dim warning and clarify other dim warnings #1491

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

rly
Copy link
Contributor

@rly rly commented Jun 30, 2022

Motivation

Fix #1490.

Also add the object class and name that generated the warning to the warning message. This is especially useful when the warning occurs on read of a file, and it is not clear which of many TimeSeries objects the warning comes from.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from bendichter June 30, 2022 00:31
@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #1491 (883c2f6) into dev (18d4cad) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev    #1491   +/-   ##
=======================================
  Coverage   78.42%   78.42%           
=======================================
  Files          37       37           
  Lines        2777     2777           
  Branches      493      493           
=======================================
  Hits         2178     2178           
  Misses        518      518           
  Partials       81       81           
Impacted Files Coverage Δ
src/pynwb/image.py 87.37% <ø> (ø)
src/pynwb/base.py 100.00% <100.00%> (ø)
src/pynwb/ecephys.py 96.39% <100.00%> (ø)
src/pynwb/ophys.py 94.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18d4cad...883c2f6. Read the comment docs.

@bendichter
Copy link
Contributor

thanks for catching this!

@bendichter bendichter merged commit 4460a1b into dev Jun 30, 2022
@rly rly deleted the fix/ophys_rois_dim_warning branch August 31, 2022 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Warning raised in RoiResponseSeries when data second dimension correctly matches length of rois
2 participants