Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support updated Images, ImageReferences, IndexSeries types #1483

Merged
merged 11 commits into from
May 24, 2022
Merged

Conversation

rly
Copy link
Contributor

@rly rly commented May 24, 2022

Motivation

NWB 2.5 will introduce changes to Images and IndexSeries and it introduces a new neurodata type ImageReferences.
See https://github.com/NeurodataWithoutBorders/nwb-schema/blob/dev/docs/format/source/format_release_notes.rst

This PR adds support for these schema changes.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@rly rly requested a review from oruebel May 24, 2022 06:34
oruebel
oruebel previously approved these changes May 24, 2022
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the flake8 test is failing, but otherwise this looks good

@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #1483 (e420e62) into dev (e05b553) will decrease coverage by 0.04%.
The diff coverage is 73.52%.

@@            Coverage Diff             @@
##              dev    #1483      +/-   ##
==========================================
- Coverage   78.28%   78.24%   -0.05%     
==========================================
  Files          37       37              
  Lines        2772     2799      +27     
  Branches      465      473       +8     
==========================================
+ Hits         2170     2190      +20     
- Misses        522      524       +2     
- Partials       80       85       +5     
Impacted Files Coverage Δ
src/pynwb/io/core.py 61.11% <ø> (-0.30%) ⬇️
src/pynwb/image.py 86.73% <52.63%> (-8.33%) ⬇️
src/pynwb/base.py 95.23% <100.00%> (+0.26%) ⬆️
src/pynwb/io/file.py 82.38% <100.00%> (+0.11%) ⬆️
src/pynwb/core.py 65.85% <0.00%> (+1.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e05b553...e420e62. Read the comment docs.

@rly rly requested a review from oruebel May 24, 2022 17:58
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@rly rly merged commit 728e0ac into dev May 24, 2022
@rly rly deleted the update_indexseries branch May 24, 2022 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants