-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support updated Images, ImageReferences, IndexSeries types #1483
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the flake8 test is failing, but otherwise this looks good
Codecov Report
@@ Coverage Diff @@
## dev #1483 +/- ##
==========================================
- Coverage 78.28% 78.24% -0.05%
==========================================
Files 37 37
Lines 2772 2799 +27
Branches 465 473 +8
==========================================
+ Hits 2170 2190 +20
- Misses 522 524 +2
- Partials 80 85 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Motivation
NWB 2.5 will introduce changes to Images and IndexSeries and it introduces a new neurodata type ImageReferences.
See https://github.com/NeurodataWithoutBorders/nwb-schema/blob/dev/docs/format/source/format_release_notes.rst
This PR adds support for these schema changes.
Checklist
flake8
from the source directory.