Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn instead of raise error if SpatialSeries has more than 3 columns #1480

Merged
merged 4 commits into from
May 19, 2022

Conversation

rly
Copy link
Contributor

@rly rly commented May 18, 2022

Motivation

Fix #1479

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1480 (de6b4f7) into dev (c9ea3f2) will increase coverage by 0.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev    #1480      +/-   ##
==========================================
+ Coverage   78.18%   78.28%   +0.10%     
==========================================
  Files          37       37              
  Lines        2759     2772      +13     
  Branches      461      465       +4     
==========================================
+ Hits         2157     2170      +13     
  Misses        522      522              
  Partials       80       80              
Impacted Files Coverage Δ
src/pynwb/behavior.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9ea3f2...de6b4f7. Read the comment docs.

@rly rly requested a review from bendichter May 18, 2022 23:31
bendichter
bendichter previously approved these changes May 19, 2022
Copy link
Contributor

@bendichter bendichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oruebel
oruebel previously approved these changes May 19, 2022
@rly rly dismissed stale reviews from oruebel and bendichter via de6b4f7 May 19, 2022 06:19
@rly rly requested a review from oruebel May 19, 2022 08:50
@rly rly merged commit e05b553 into dev May 19, 2022
@rly rly deleted the warn_spatial_series_cols branch May 19, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot read file with SpatialSeries with >3 columns
3 participants