Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add behavior tutorial #1464

Merged
merged 19 commits into from
May 3, 2022
Merged

Add behavior tutorial #1464

merged 19 commits into from
May 3, 2022

Conversation

weiglszonja
Copy link
Collaborator

@weiglszonja weiglszonja commented Apr 26, 2022

Motivation

Create a new tutorial that demonstrates how to use the behavior module for adding behavior data to an NWB File.

The behavioral tutorial covers the following neurodata types:

  • SpatialSeries
  • Position
  • CompassDirection
  • BehavioralTimeSeries
  • BehavioralEvents
  • BehavioralEpochs
  • PupilTracking
  • EyeTracking

resolves #1456

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@weiglszonja weiglszonja marked this pull request as draft April 26, 2022 12:44
@weiglszonja weiglszonja self-assigned this Apr 26, 2022
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1464 (0892d10) into dev (2973aeb) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1464   +/-   ##
=======================================
  Coverage   77.47%   77.47%           
=======================================
  Files          37       37           
  Lines        2735     2735           
  Branches      455      455           
=======================================
  Hits         2119     2119           
  Misses        535      535           
  Partials       81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2973aeb...0892d10. Read the comment docs.

@weiglszonja weiglszonja marked this pull request as ready for review April 29, 2022 16:19
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks good. I added a few very minor comments, but otherwise this looks good to me. Thanks for putting this tutorial together!

@weiglszonja
Copy link
Collaborator Author

Thank you @oruebel and @bendichter for the suggestions, I incorporated them.

oruebel
oruebel previously approved these changes May 3, 2022
Copy link
Contributor

@oruebel oruebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

CHANGELOG.md Outdated Show resolved Hide resolved
@oruebel
Copy link
Contributor

oruebel commented May 3, 2022

@bendichter good to merge?

@bendichter
Copy link
Contributor

looks good to me!

@bendichter bendichter merged commit 89f085a into dev May 3, 2022
@CodyCBakerPhD CodyCBakerPhD deleted the docs/add_behavior_tutorial branch May 18, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation]: add advanced behavior tutorial
3 participants