Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose logo for PyNWB #1461

Merged
merged 5 commits into from
Apr 22, 2022
Merged

Propose logo for PyNWB #1461

merged 5 commits into from
Apr 22, 2022

Conversation

oruebel
Copy link
Contributor

@oruebel oruebel commented Apr 22, 2022

Motivation

I was working on logos, so I figured I'd give it a shot to make a logo for PyNWB. What do you think?

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@oruebel oruebel added category: proposal proposed enhancements or new features topic: docs issues related to documentation labels Apr 22, 2022
@oruebel oruebel requested review from bendichter and rly April 22, 2022 03:59
@rly
Copy link
Contributor

rly commented Apr 22, 2022

I like it!

Looks like one of the gallery tutorials references logo.png. This will have to be updated.

bendichter
bendichter previously approved these changes Apr 22, 2022
Copy link
Contributor

@bendichter bendichter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very cool!

@codecov
Copy link

codecov bot commented Apr 22, 2022

Codecov Report

Merging #1461 (f41a73f) into dev (79183f2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #1461   +/-   ##
=======================================
  Coverage   77.46%   77.46%           
=======================================
  Files          37       37           
  Lines        2733     2733           
  Branches      455      455           
=======================================
  Hits         2117     2117           
  Misses        535      535           
  Partials       81       81           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79183f2...f41a73f. Read the comment docs.

@oruebel
Copy link
Contributor Author

oruebel commented Apr 22, 2022

Looks like one of the gallery tutorials references logo.png. This will have to be updated.

Thanks for pointing me to the error. This is fixed now.

I'm glad that we are running the galleries as part of the CI. When building the docs on my laptop this error did not get triggered because sphinx gallery does not seem to run that tutorial when building the docs, probably because it doesn't have the plot prefix to indicate that we want to capture the output of code cells for this particular tutorial. This error is fixed now.

@oruebel
Copy link
Contributor Author

oruebel commented Apr 22, 2022

@rly can you please reapprove

@oruebel oruebel merged commit 35b635d into dev Apr 22, 2022
@oruebel oruebel deleted the propose/pynwb_logo branch April 22, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: proposal proposed enhancements or new features topic: docs issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants