Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NWB Basics tutorial #1403

Merged
merged 55 commits into from
Mar 16, 2022

Conversation

weiglszonja
Copy link
Collaborator

@weiglszonja weiglszonja commented Aug 21, 2021

Extends the NWB File Basics tutorial with:

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@weiglszonja weiglszonja marked this pull request as draft August 21, 2021 19:04
@oruebel
Copy link
Contributor

oruebel commented Aug 22, 2021

Just a heads up. I also made some changes to docs/gallery/general/file.py to merge the content of docs/source/overview_nwbfile.rst with the tutorial in the following PR #1402

@weiglszonja
Copy link
Collaborator Author

weiglszonja commented Aug 23, 2021

@oruebel Thanks for the heads-up! I'll close this PR and create a new tutorial page focusing on adding behavior data that is not covered yet in the tutorials (Subject, SpatialSeries, Position, etc.) or I can merge your changes here; What do you think?

@oruebel
Copy link
Contributor

oruebel commented Aug 23, 2021

create a new tutorial page focusing on adding behavior data

@weiglszonja I agree, adding a tutorial focused on behavioral data will be useful. Depending on the scope that tutorial may fit well in the "Domain-specific tutorials" section.

BTW, if there are any changes from this PR that you think should remain part of the "NWB File basics" tutorial instead, then please feel free to make those changes in this or a new PR. I mainly wanted to give you a heads up about the other PR in case of merge conflicts. However, since the other PR mainly expands on the intro part of the "NWB File basics" tutorial, I don't think merging the changes should be too complicated.

@bendichter
Copy link
Contributor

bendichter commented Nov 24, 2021

@rly can we enable this feature? https://docs.readthedocs.io/en/stable/pull-requests.html I don't have the readthedocs credentials (or don't know them)

@rly
Copy link
Contributor

rly commented Mar 11, 2022

@rly rly requested a review from bendichter March 11, 2022 17:20
correct an NWBHDF5IO.read link
remove the "Adding More Data" section
@bendichter
Copy link
Contributor

@rly I made a few more adjustments. Good to go from my end!

@rly rly merged commit 4fe05f4 into NeurodataWithoutBorders:dev Mar 16, 2022
@rly rly deleted the update_basics_tutorial branch March 16, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants