Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment-ros3.yml to MANIFEST.in #1398

Merged
merged 2 commits into from
Aug 13, 2021
Merged

Add environment-ros3.yml to MANIFEST.in #1398

merged 2 commits into from
Aug 13, 2021

Conversation

rly
Copy link
Contributor

@rly rly commented Aug 13, 2021

Motivation

environment-ros3.yml was added in PyNWB 2.0 but not added to MANIFEST.in. It should be added so that it can be included in source distributions alongside the requirements files.

This file is currently used only by CI processes, but conda users may wish to use it to set up a working ROS3-compatible conda environment.

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #1398 (5a1a150) into dev (a27200d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1398   +/-   ##
=======================================
  Coverage   77.26%   77.26%           
=======================================
  Files          37       37           
  Lines        2714     2714           
  Branches      450      450           
=======================================
  Hits         2097     2097           
  Misses        535      535           
  Partials       82       82           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a27200d...5a1a150. Read the comment docs.

@rly rly merged commit 5fcd364 into dev Aug 13, 2021
@rly rly deleted the fix/manifest branch August 13, 2021 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants