ENH: Ensure that sys.path has the current directory in setup.py #1395
+7
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I tried to install the latest
dev
branch usingpip
in an embedded Python on Windows, and got errorModuleNotFoundError: No module named 'versioneer'
insetup.py
.This is a typical error with embedded Python because it does not add the current directory to
PYTHONPATH
.h5py fixed this issue two years ago by explicitly adding
''
tosys.path
insetup.py
.This PR makes the same change here.
How to test the behavior?
On Windows, using PowerShell
Before the change:
After the change, everything installs correctly:
Checklist
flake8
from the source directory.