Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HDMF 2.3 #1325

Merged
merged 11 commits into from
Dec 9, 2020
Merged

Add support for HDMF 2.3 #1325

merged 11 commits into from
Dec 9, 2020

Conversation

rly
Copy link
Contributor

@rly rly commented Dec 8, 2020

Motivation

HDMF 2.3 introduces a few changes. This PR addresses those changes and updates the requirements to require hdmf >= 2.3.

Checklist

  • Have you checked our Contributing document?
  • Have you ensured the PR description clearly describes problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using #XXX notation where XXX is the issue number?

@rly rly mentioned this pull request Dec 8, 2020
@rly rly changed the title Add support for HDMF 3.0 Add support for HDMF 2.3 Dec 9, 2020
@rly rly requested review from ajtritt, bendichter and oruebel December 9, 2020 05:34
@bendichter
Copy link
Contributor

@rly this also add support for 3.0?

@ajtritt
Copy link
Member

ajtritt commented Dec 9, 2020

@rly this also add support for 3.0?

No, h5py 3.x support is not complete. It will likely be non-backward compatible

@bendichter
Copy link
Contributor

@ajtritt ok. I'm trying to test out hdmf enh/h5py 3.x with pynwb and nwbwidgets. Would I have to take those changes and apply them to hdmf 2.3? Then use this branch of pynwb (or dev once it's merged)?

@bendichter
Copy link
Contributor

It appears I got confused between the different packages. I thought there was an HDMF 3.0, but I was probably confusing that with the h5py 3.0 support.

@rly
Copy link
Contributor Author

rly commented Dec 9, 2020

We were initially planning to release HDMF as version 3.0 but the breaking changes were not so important and support for h5py 3.x would be another breaking change, so we decided to pull the breaking changes out of the just-released release (2.3) and save them for an upcoming release that supports h5py 3.x.

@rly rly merged commit ceaa93a into dev Dec 9, 2020
@rly rly deleted the hdmf_3.0 branch December 9, 2020 17:12
@bendichter
Copy link
Contributor

We were initially planning to release HDMF as version 3.0 but the breaking changes were not so important and support for h5py 3.x would be another breaking change, so we decided to pull the breaking changes out of the just-released release (2.3) and save them for an upcoming release that supports h5py 3.x.

Thanks, this makes perfect sense and clarifies my confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants