-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for HDMF 2.3 #1325
Add support for HDMF 2.3 #1325
Conversation
@rly this also add support for 3.0? |
No, h5py 3.x support is not complete. It will likely be non-backward compatible |
@ajtritt ok. I'm trying to test out hdmf enh/h5py 3.x with pynwb and nwbwidgets. Would I have to take those changes and apply them to hdmf 2.3? Then use this branch of pynwb (or dev once it's merged)? |
It appears I got confused between the different packages. I thought there was an HDMF 3.0, but I was probably confusing that with the h5py 3.0 support. |
We were initially planning to release HDMF as version 3.0 but the breaking changes were not so important and support for h5py 3.x would be another breaking change, so we decided to pull the breaking changes out of the just-released release (2.3) and save them for an upcoming release that supports h5py 3.x. |
Thanks, this makes perfect sense and clarifies my confusion. |
Motivation
HDMF 2.3 introduces a few changes. This PR addresses those changes and updates the requirements to require hdmf >= 2.3.
Checklist
flake8
from the source directory.#XXX
notation whereXXX
is the issue number?