-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide default options for chunking of datasets (issue #635) #636
base: main
Are you sure you want to change the base?
Conversation
Some open questions:
|
Current implementation for schema/definition:
Open questions:
What would be the syntax?
|
Need to determine what to do with nested data types. For example: A RoiResponseSeries can be part of a Fluorescence or a DfOverF group. Should the spec support defining configuration for nested neurodata types dependent on were they are located, i.e:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #636 +/- ##
==========================================
- Coverage 95.27% 94.79% -0.48%
==========================================
Files 124 132 +8
Lines 5139 5301 +162
==========================================
+ Hits 4896 5025 +129
- Misses 243 276 +33 ☔ View full report in Codecov by Sentry. |
…ataWithoutBorders/matnwb into 635-customizable-chunking
…ad of chunkConfiguration
Replaces switch block with formatted string
…ataWithoutBorders/matnwb into 635-customizable-chunking
…ataWithoutBorders/matnwb into 635-customizable-chunking
…ataWithoutBorders/matnwb into 635-customizable-chunking
Function that will ensure the dataset configuration conforms with MatNWB specific implementation details
Co-authored-by: Ben Dichter <[email protected]>
Resolve name for dataset if the name field is missing
Rename flexible dimension to "flex" Use product of fixed dimensions to compute size of flex dimension
Add function to update dataset configuration to conform with MatNWB specific implementation (i.e, Dataset types (like VectorData) having a data property)
…ataWithoutBorders/matnwb into 635-customizable-chunking
Fix #635
Motivation
Provide better chunking options for files in cloud storage
How to test the behavior?
To be determined
Checklist
fix #XX
whereXX
is the issue number?