Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #583: test tutorial files across languages #587

Merged
merged 18 commits into from
Sep 10, 2024
Merged

Fix issue #583: test tutorial files across languages #587

merged 18 commits into from
Sep 10, 2024

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Sep 7, 2024 •
edited by bendichter
Loading

Fix #583

Motivation

Improve testing across matnwb and pynwb through reading nwb files produced by matnwb tutorials using pynwb and vice versa

How to test the behavior?

testSuiteMatnwbTutorials = matlab.unittest.TestSuite.fromClass(?tests.unit.TutorialTest)
testSuitePynwbTutorials = matlab.unittest.TestSuite.fromClass(?tests.unit.PynwbTutorialTest)

runner = matlab.unittest.TestRunner.withTextOutput()
results = runner.run([testSuiteMatnwbTutorials, testSuitePynwbTutorials])

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@ehennestad
Remove tutorialTest (function-based)
59ed0a2
@ehennestad
Create TutorialTest (class-based unit test)
e386d6c
@ehennestad
Add test classes (issue #583 )
135b59e
@ehennestad
Update description for PynwbTutorialTest
7196f50
@ehennestad
Create getTutorialNwbFilePath.m
878d1c7 
Add function to create a filepath for saving tutorial nwb files in a fixed folder
@ehennestad
Fix: Add starting_time when creating TimeSeries objects (#584)
9cc1ec4 
Also, use misc.getTutorialNwbFilePath to create a filepath for saving tutorial nwb file
@ehennestad
Update several tutorials: Specify timezone or NWBFile's session_start…
6ed7104 
…_time property
@ehennestad
Update PynwbTutorialTest.m
4df3c88 
Add "extensions" tutorial to skipped tutorials as it has an unresolved issue
@ehennestad
Fix dynamic_tables tutorial
608adef 
Specify timezone for session start time when creating nwb object
Fix maxSize of DataPipe in random_exp_index (VectorIndex object)
@ehennestad
Added context and details to the dimension mapping tutorials
b1b252f
@ehennestad
Fix dimensionMapWithDataPipes tutorial, ignore outfile in test
ee8ca49
@bendichter bendichter merged commit 529e086 into master Sep 10, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bendichter bendichter bendichter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Testing] Add tests for reading tutorial NWB files with pynwb and vice versa
2 participants
@ehennestad @bendichter