Skip to content

Actually exit the function if dataset is not resizable #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

lawrence-mbf
Copy link
Collaborator

Motivation

H5D might actually still fail even if a warning is emitted. Should actually exit to not risk breaking writes since we shouldn't be writing anyway.

How to test the behavior?

Attempt to modify a pynwb-generated file. You might (or might not) actually encounter the error with /file_create_date

Checklist

  • Have you ensured the PR description clearly describes the problem and solution?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@lawrence-mbf lawrence-mbf self-assigned this Oct 23, 2023
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #551 (9177afe) into master (5d813aa) will decrease coverage by 0.05%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #551      +/-   ##
==========================================
- Coverage   87.82%   87.78%   -0.05%     
==========================================
  Files         132      132              
  Lines        5628     5631       +3     
==========================================
  Hits         4943     4943              
- Misses        685      688       +3     
Files Coverage Δ
+io/writeDataset.m 83.33% <83.33%> (-7.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lawrence-mbf lawrence-mbf merged commit e0e4aa0 into master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant