-
Notifications
You must be signed in to change notification settings - Fork 33
add new raw/scratch script #534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Anon and External Links may point to other group-like objects (like Links and other wrapper types). CheckDType now resolves this recursively with extra checks for loops.
Codecov Report
@@ Coverage Diff @@
## master #534 +/- ##
=======================================
Coverage 87.71% 87.72%
=======================================
Files 132 132
Lines 5584 5620 +36
=======================================
+ Hits 4898 4930 +32
- Misses 686 690 +4
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@lawrence-mbf thanks for putting this together!
func( ...
'arg', arg ...
, 'arg2', arg2'); to func( ...
'arg', arg, ...
'arg2', arg2'); For the tutorials, I am adopting a style that is an approximate translation from Python's Black. I appreciate that your approach provides the benefit that removing a line only changes that one line, and accounts for the fact that a trailing is allowed in Python but not in MATLAB. However, I have never seen code in this style and I think it might be confusing. Are you following an established style standard here? Otherwise, I'd prefer to bite the bullet and put the commas on the line of the arg, even though I appreciate the point that we are losing the benefit of having line changes be completely self-contained.
|
(1) Regarding multiline function styleAFAIK there is no coding standard in MATLAB other than auto-indentation (CTRL+I). This adoption is purely from modifying MATLAB's name-value args. I'm not sure why adopting a python-specific style would help MATLAB style but I can change that for the script anyway. (3) External LinksThis was pulled from the documentation here and I'm trying to follow the major topic as closely as I can. It is true that external linkage is a viable solution for data analysis so I wanted to make that clear that you can do that too (albeit, manually). Note that the pynwb documentation does refer to External Links but refers to the feature (confusingly) as "Copying" which is not a feature in MatNWB but does use external links when doing so. |
- uses python's black-like multiline argument structure
- Remove extraneous external links section - Update link text to scratch tutorial
@bendichter @oruebel updated with suggestions |
Motivation
Adds Raw/Scratch tutorial from this pynwb guide
How to test the behavior?
Documentation should be correct and cover the same topics
Checklist
fix #XX
whereXX
is the issue number?