Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when schema is not supported #531

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

lawrence-mbf
Copy link
Collaborator

Motivation

Fixes #499

How to test the behavior?

Attempt to call nwbRead on a file using a non-standard schema.

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #531 (c2cd517) into master (286d6b5) will decrease coverage by 0.06%.
The diff coverage is 44.44%.

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
- Coverage   87.71%   87.66%   -0.06%     
==========================================
  Files         132      132              
  Lines        5584     5592       +8     
==========================================
+ Hits         4898     4902       +4     
- Misses        686      690       +4     
Files Changed Coverage Δ
nwbRead.m 77.14% <44.44%> (-2.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lawrence-mbf lawrence-mbf marked this pull request as ready for review August 30, 2023 15:39
@lawrence-mbf lawrence-mbf merged commit 68c9e12 into master Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: give descriptive error when failing to open unsupported NWB format
1 participant