Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shrink int to auto-map to int8 #523

Merged
merged 1 commit into from
Jul 25, 2023
Merged

shrink int to auto-map to int8 #523

merged 1 commit into from
Jul 25, 2023

Conversation

lawrence-mbf
Copy link
Collaborator

Fixes #486

Motivation

Allows auto-shrink to all integer types.

How to test the behavior?

tests should be successful when exported by MatNWB and read in by PyNWB.

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #523 (31529a5) into master (461c5c4) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #523   +/-   ##
=======================================
  Coverage   87.89%   87.89%           
=======================================
  Files         129      129           
  Lines        5461     5461           
=======================================
  Hits         4800     4800           
  Misses        661      661           
Files Changed Coverage Δ
+file/mapType.m 94.28% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lawrence-mbf lawrence-mbf self-assigned this Jul 25, 2023
@lawrence-mbf lawrence-mbf marked this pull request as ready for review July 25, 2023 18:33
@lawrence-mbf lawrence-mbf merged commit a6245ac into master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Map int in schema to int8 Minimum Type
1 participant