Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow string inputs for most interfaces #522

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Conversation

lawrence-mbf
Copy link
Collaborator

Fixes #287

Motivation

Allow for strings since these may be used by users.

How to test the behavior?

Using any of the generateCore, generateExtension, nwbRead, or nwbExport with double-quotes instead of single quotes should not cause errors.

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@lawrence-mbf lawrence-mbf changed the title 287 allow string input Allow string inputs for most interfaces Jul 25, 2023
@lawrence-mbf lawrence-mbf self-assigned this Jul 25, 2023
@lawrence-mbf lawrence-mbf marked this pull request as ready for review July 25, 2023 18:17
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #522 (f48a5d6) into master (461c5c4) will decrease coverage by 0.05%.
The diff coverage is 84.12%.

@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
- Coverage   87.89%   87.84%   -0.05%     
==========================================
  Files         129      129              
  Lines        5461     5489      +28     
==========================================
+ Hits         4800     4822      +22     
- Misses        661      667       +6     
Files Changed Coverage Δ
nwbExport.m 55.55% <55.55%> (-15.88%) ⬇️
nwbRead.m 79.38% <80.85%> (+0.49%) ⬆️
generateExtension.m 90.32% <90.32%> (-2.54%) ⬇️
generateCore.m 95.45% <95.45%> (+0.21%) ⬆️
+types/+untyped/DataStub.m 95.15% <100.00%> (+0.08%) ⬆️
+types/+untyped/ExternalLink.m 95.77% <100.00%> (+0.25%) ⬆️
+types/+untyped/ObjectView.m 88.00% <100.00%> (+1.04%) ⬆️
+types/+untyped/SoftLink.m 91.42% <100.00%> (+0.80%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lawrence-mbf lawrence-mbf merged commit 0d334ed into master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

char required for generating extension
1 participant