Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct optional dep for publishing on PyPi #205

Merged
merged 7 commits into from
Jun 15, 2021
Merged

Conversation

sylvchev
Copy link
Member

Could not publish on PyPi:

HTTP Error 400: Invalid value for requires_dist. Error: Can't have direct dependency: 'tdlda @ git+https://github.com/jsosulski/[email protected] ; extra == "external"'

PyPi does not support non-package dependencies and url as package, as it is the case here for tdlda

@sylvchev
Copy link
Member Author

It is not possible to put tdlda in dev dependency as an extra : see python-poetry/poetry#759. Dependency groups will be available in poetry 1.2.0 : python-poetry/poetry#1644

Meanwhile, I put tdlda in dev and updated all Github Actions to install only main dep in test and main+dev in docs. Checking everything on a local server, I corrected two errors in unit tests when datasets are already downloaded

@sylvchev sylvchev merged commit f87932f into master Jun 15, 2021
@sylvchev sylvchev deleted the hotfix/gitdep-pypi branch September 3, 2021 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant