PR 407 + tweaks #421
Merged
PR 407 + tweaks #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll use these to test our implementation
`create_unbranche_segment` adds one to the root segments of all unbranched segment groups
The first two points belong to the first segment in this case also, and that needed to be correctly recorded. Otherwise, other segments that have the second point as the parent were not referring to the first segment as the parent segment---they were referring to the next segment where the second point was the proximal, not the distal.
This was
linked to
issues
Sep 4, 2024
Closed
Also regenerates all man pages [skip ci]
Use better variable names to clarify what point is being used. Also correctly map points to their corresponding segments.
Otherwise some of our test files don't get committed.
There's no need to store the segment groups in another data structure and do another pass to create them. We can keep adding the segments to the segment groups as we go.
For some files, iterating over both files takes quite a while.
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @AdityaBITMESRA : working on your PR here