Deps and CI fixes #395
Merged
Deps and CI fixes #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until our deps, like pytables catch up.
The use of `pull_request_target` makes it hard to test CI since it uses the base configuration rather than the CI config from the PR. So let's drop it. We'll just keep an eye out on the coverage manually.
It does not currently build/install on py3.12: mcfletch/pyopengl#118
|
@pgleeson : this will fix CI for 3.12. I've pinned numpy since pytables isn't ready for 2.x, and limited pyopengl-accelerate, which isn't available on 3.12 yet. Doesn't touch any code. Merging this in now. |
|
Thanks. A number of other repos' tests failing too due to this numpy version... |
|
Yeh, we're going to have to carry that for a bit until the whole ecosystem of deps catches up :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.