-
Notifications
You must be signed in to change notification settings - Fork 35
animate matplotlib plots #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sanjayankur31
merged 12 commits into
NeuroML:feat/test-animate-plots
from
YBCS:buda-plt
May 16, 2024
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
bca04af
wip plot animate
YBCS f974126
Merge branch 'development' into buda-plt
YBCS c6b45a7
chore: add animate hyperparams to plot
YBCS cb5d3f9
test(plotting): add test for animated plots
sanjayankur31 04c498d
chore: improve animation hyperparameters and introduce saving animation
YBCS efe323f
Merge pull request #1 from NeuroML/feat/plot-animated-test
YBCS 6629a5d
Merge branch 'buda-plt' of https://github.com/YBCS/pyNeuroML into bud…
YBCS bb4a517
Merge branch 'development' into buda-plt
YBCS 3437ba4
feat: add -save_animation_to param
YBCS 8a8e785
feat: add animate_duration arg for plot
YBCS fc5be81
feat: add animate_writer support and tests
YBCS a632d6c
rename duplicate test name
YBCS File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[xs1, xs2] is it possible that this list contains items with differing lengths. can xs1 and xs2 have different lengths ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think they can, but [y1, y2] must have the same lengths as [x1, x2] so that matplotlib has complete (x,y) co-ordinates for each point.
For animation, one will have to find the values with the longest length and use that to calculate duration and all that then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that will be correct as, [plt1, plt2] are individual plots and we only care of the total duration which means the max of the lengths