To v1.1.0; Update to jnml v0.12.3 jar #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So users can just change the argument of this method and not have to modify the method itself in their scripts/code
It seems these are not re-generated by jnml if they already exist, and so, they're not picked up here. Simplest to delete them all so that they are always regenerated
Just makes it easier to test
This function - gets a list of all the LEMS/NeuroML files that are required - copies them to a new, clean directory - generates all the simulation engine related files - creates a zip with all these to send to NSG - sends to NSG If it is not interrupted, when the job finishes, the data from the job is also downloaded to the new runner directory.
Copy commands do not re-create missing directories in the destination path, so we need to re-create them manually.
Feat/nsgr integration
Generate pngs of tests in same dirs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.