Skip to content

Conversation

@sanjayankur31
Copy link
Member

WIP: need to add some tests

@sanjayankur31 sanjayankur31 added the T: enhancement Type: enhancement label Oct 14, 2022
@sanjayankur31 sanjayankur31 marked this pull request as ready for review October 17, 2022 13:23
@sanjayankur31
Copy link
Member Author

@shayan823: since you've worked with this one quite a bit---how does this look? It just includes it into the pyneuroml.neuron module basically, doesn't change the logic at all.

@pgleeson : should be ready to merge already---didn't change the logic of the functions at all.

@sanjayankur31
Copy link
Member Author

@sanjayankur31
Copy link
Member Author

We can include this in the release too @pgleeson : doesn't modify any older code, just refactors it to include the mod2nml function in the pyneuroml.neuron sub module

@pgleeson
Copy link
Member

Sure, thanks!

@pgleeson pgleeson merged commit 20992e7 into development Oct 17, 2022
@sanjayankur31 sanjayankur31 deleted the feat/document-convert-mod-to-neuroml branch October 17, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T: enhancement Type: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants