Skip to content

Feat/use webgl interactive plot #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Feat/use webgl interactive plot #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ad40b3
feat(interactive-plot): use gl variant for performance
sanjayankur31 Aug 10, 2022
39e791b
test(plot): add more points to test performance
sanjayankur31 Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyneuroml/plot/Plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ def generate_interactive_plot(

for i in range(len(xvalues)):
fig.add_trace(
go.Scatter(
go.Scattergl(
x=xvalues[i],
y=yvalues[i],
name=labels[i],
Expand Down
12 changes: 6 additions & 6 deletions tests/plot/test_plot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,21 +64,21 @@ def test_generate_interactive_plot(self):
except FileNotFoundError:
pass

xs = [*range(5, 15)]
ys = [*range(5, 15)]
xs1 = [*range(5, 15)]
ys1 = [*range(14, 4, -1)]
xs = [*range(5, 15000)]
ys = [*range(5, 15000)]
xs1 = [*range(5, 15000)]
ys1 = [*range(14999, 4, -1)]
labels = ["up", "down"]
generate_interactive_plot(
xvalues=[xs, xs1],
yvalues=[ys, ys1],
labels=labels,
modes=["lines+markers", "markers"],
title="test interactive plot",
title=f"test interactive plot with {len(xs) * 2} points",
plot_bgcolor="white",
xaxis="x axis",
yaxis="y axis",
show_interactive=False,
show_interactive=True,
xaxis_spikelines=True,
yaxis_spikelines=False,
save_figure_to=filename,
Expand Down