Skip to content

Conversation

@sanjayankur31
Copy link
Member

No description provided.

@sanjayankur31 sanjayankur31 marked this pull request as ready for review August 9, 2022 08:07
@sanjayankur31 sanjayankur31 requested a review from pgleeson August 9, 2022 08:07
@sanjayankur31
Copy link
Member Author

@irahulsonkar @anujanegi @shayan823: interactive 3D plotting of morphologies is here now. it's still a naive implementation, so it'll improve. Do take a look and let us what you think.
testcell
olm

@sanjayankur31
Copy link
Member Author

Note, this may conflict a little with #176, but I can sort any merge conflicts that may crop up after that is merged.

@sanjayankur31 sanjayankur31 added T: enhancement Type: enhancement S: ready for review Status: ready for review labels Aug 9, 2022
@pgleeson
Copy link
Member

pgleeson commented Aug 9, 2022

@sanjayankur31 Merged plotly changes to dev, but small conflict here now...

@sanjayankur31
Copy link
Member Author

merged dev into it and resolved conflicts. Should be good now.

sanjayankur31 and others added 11 commits August 10, 2022 13:06
* feat/nml2matplotlib: (23 commits)
  feat(morph-plot-3d): implement min width
  feat(morph-plot-2d): implement option to provide minimum line width
  docs: add PlotMorphology to docs
  feat: add plotly etc to dev requirements
  chore: add note about WebGL to 3D morph plotter
  feat(morphology-plot): add 3D interactive plotter
  feat: add pynml-plotmorph script and update man pages
  test(morphology-plotter): complete tests
  feat(morphology-plotter): add scalebar
  test(morphology-plot): test with simple and complex morphology
  feat(morphology-plot): check for all variations of plane names
  feat(plot): add tests for morphology plotter
  test(plot): copy over init file
  tests: init tests for plotting
  chore: remove unused import
  feat: make utils a package by adding __init__.py
  feat(morph-plotting): refactor and add dummy 3d plotter function
  chore: add utils submodule to packages
  refactor(utils): move argparser to utils module
  chore: format
  ...
@sanjayankur31 sanjayankur31 merged commit 319bb78 into development Aug 12, 2022
@sanjayankur31 sanjayankur31 deleted the feat/nml2matplotlib branch August 12, 2022 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S: ready for review Status: ready for review T: enhancement Type: enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants