Skip to content

Conversation

@shayanshafquat
Copy link
Contributor

No description provided.

@sanjayankur31
Copy link
Member

So we're just making sure that the background for the channel notes is white---was this causing an issue (with GitHub dark mode?)

@shayanshafquat
Copy link
Contributor Author

shayanshafquat commented Jun 29, 2022

I tried adding the channel notes in a div tag as well. Actually, the line breaks in the notes of the neuroml file are not allowing the images to render properly.
When tried adding max-width=120px to the td tag it wasnt helping so I reverted it back.

Currently, the images are rendered properly except that the text in the first column is wrapped. Have a look at this.

@pgleeson
Copy link
Member

@shayan823 Just to clarify, are you saying this is a fix already or still being tested?

@shayanshafquat
Copy link
Contributor Author

shayanshafquat commented Jun 29, 2022

It's still being tested. As its fails to render the image when we have line breaks in the notes.
We can parse the channel NeuroML files such that notes have no line breaks keeping the template as in this commit.

@pgleeson
Copy link
Member

FYI the use of <sup> was a quick and dirty hack to allow small text for the longish descriptions. There is certainly a better way to do that which may give less problems...

@pgleeson pgleeson merged commit 9092610 into NeuroML:development Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants