Skip to content

Commit

Permalink
ci: fix node20 compatibility issues in e2e pipeline (#606)
Browse files Browse the repository at this point in the history
e2e pipeline fails on Ubuntu 16.04 and 18.04 due to the recent default
switch to node20 in actions/checkout. Node20 requires GLIBC 2.28 or
higher, which these environments lack. To resolve this, we’re setting
the `ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true` environment variable
to allow fallback to a compatible Node version, restoring pipeline
stability.

Useful links:
* [GitHub changelog: node20
default](https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/)
* [GitHub issue #1809](actions/checkout#1809)
  • Loading branch information
maksadbek authored Nov 11, 2024
1 parent 6e57c57 commit 714e36e
Showing 1 changed file with 9 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ jobs:
if: ${{ inputs.test-executables }}
runs-on: ${{ matrix.os }}
container: ${{ matrix.container }}
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -125,6 +128,7 @@ jobs:
E2E_REPEATER_TARGET_URL: ${{ format('http://localhost:{0}', steps.target.outputs.port) }}
E2E_REPEATER_TARGET_CMD: ${{ steps.target.outputs.cmd }}
E2E_TEST_TIMEOUT: ${{ inputs.test_timeout }}

msi:
if: ${{ inputs.test-msi }}
runs-on: windows-latest
Expand Down Expand Up @@ -175,6 +179,7 @@ jobs:
E2E_REPEATER_TARGET_URL: ${{ format('http://localhost:{0}', steps.target.outputs.port) }}
E2E_REPEATER_TARGET_CMD: ${{ steps.target.outputs.cmd }}
E2E_TEST_TIMEOUT: ${{ inputs.test_timeout }}

docker:
if: ${{ inputs.test-docker }}
runs-on: ${{ matrix.os }}
Expand Down Expand Up @@ -217,10 +222,14 @@ jobs:
E2E_REPEATER_TARGET_URL: ${{ format('http://host.docker.internal:{0}', steps.target.outputs.port) }}
E2E_REPEATER_TARGET_CMD: ${{ steps.target.outputs.cmd }}
E2E_TEST_TIMEOUT: ${{ inputs.test_timeout }}

npm:
if: ${{ inputs.test-npm }}
runs-on: ${{ matrix.os }}
container: ${{ matrix.container }}
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

strategy:
fail-fast: false
matrix:
Expand Down

0 comments on commit 714e36e

Please sign in to comment.