Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operator pages improvements #105

Merged
merged 12 commits into from
Jul 8, 2024
Merged

Operator pages improvements #105

merged 12 commits into from
Jul 8, 2024

Conversation

Zishan-7
Copy link
Collaborator

@Zishan-7 Zishan-7 commented Jul 4, 2024 •
edited
Loading

Changes

  • Updated Operator details layout
  • Added loading state in Operator list page
  • Fixed sidebar not showing active tab in nested routes
  • Added Operator rank/serial number
  • Updated default timeline for graphs to all
  • Fixed number formatting
  • added dummy text for Operators with missing metadata

@Zishan-7 Zishan-7 marked this pull request as ready for review July 8, 2024 07:35
vincenthongzy
vincenthongzy approved these changes Jul 8, 2024
View reviewed changes
Copy link
Collaborator

@vincenthongzy vincenthongzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zishan-7 Zishan-7 merged commit c56b153 into new Jul 8, 2024
@Zishan-7 Zishan-7 deleted the fix/op-page-improvements branch July 8, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincenthongzy vincenthongzy vincenthongzy approved these changes

@rubo rubo Awaiting requested review from rubo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Zishan-7 @vincenthongzy