fix(cluster): hash unsigned v1.3/v1.4 operator signatures as raw bytes - #642
Open
iamquang95 wants to merge 1 commit into
Open
fix(cluster): hash unsigned v1.3/v1.4 operator signatures as raw bytes#642iamquang95 wants to merge 1 commit into
iamquang95 wants to merge 1 commit into
Conversation
iamquang95
commented
Aug 13, 2026
|
|
||
| // Field (2) 'ConfigSignature' Bytes65 | ||
| put_bytes_n(hh, &o.config_signature, SSZ_LEN_K1_SIG)?; | ||
| hh.put_bytes(&o.config_signature) |
Collaborator
Author
There was a problem hiding this comment.
https://github.com/ObolNetwork/charon/blob/v1.7.1/cluster/ssz.go#L243-L247
// Field (2) 'ConfigSignature' Bytes65
hh.PutBytes(o.ConfigSignature)
// Field (3) 'ENRSignature' Bytes65
hh.PutBytes(o.ENRSignature)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #633
hash_definition_v1x3or4left-padded operatorconfig_signature/enr_signatureto 65 bytes; charon (ssz.go:244-247) writes the raw bytes. Signed definitions coincide (already 65 bytes), but unsigned/partially-signed v1.3/v1.4 definitions hashed differently, soverify_hashes()rejected charon-produced artifacts.put_bytes(v1x5to9 and the creator field were already correct).get_operator_eip712_typenow returnsErr(UnsupportedVersion)instead ofunreachable!()on a version string coming from definition JSON.SetDefinitionHashes(), not from pluto's output; verified the test fails against the old code. All existing signed-path fixtures unchanged.