fix(relay): match charon circuit duration, require TCP addresses - #629
Merged
Conversation
…ect --debug-address
varex83
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #624
max_circuit_durationwas 1 minute; charon keeps relayed circuits for 1 hour. The 60× gap tore down every long-lived relayed circuit after 60s, forcing constant reconnect churn. Now 1 hour.pluto relaywithout--p2p-tcp-addressnow fails with charon's exact error, "p2p TCP addresses required". The check lives in the CLI config conversion (where relay flag validation lives) rather than inrelay-server/src/p2p.rs, to avoid colliding with Unify TCP/QUIC transport building #621 which owns that file — every production path goes through the conversion, so nothing can reach node startup unguarded. Adding the same guard at the library boundary inp2p.rsis left to Unify TCP/QUIC transport building #621.--debug-address: was parsed but silently ignored. It now errors with "flag '--debug-address' is not yet supported by pluto relay" (same pattern asrun's unsupported-flag checks), rather than pretending a debug server exists.