Comments on Xdc README #9950
Open
Comments on Xdc README #9950
+35
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ak88
reviewed
Jan 9, 2026
| **Purpose**: Manage validator set transitions at epoch boundaries | ||
|
|
||
| **Epoch Structure**: | ||
| // This figure is not clear for me, let's add more explanation |
Contributor
There was a problem hiding this comment.
replaced with a simpler explanation.
| Address Beneficiary | ||
| Hash256 StateRoot | ||
| long Number | ||
| long Number // in Golang, it's `*big.Int`. Is it okay to use `long` here? |
Contributor
There was a problem hiding this comment.
Yes this is no problem since in RLP its uint64
| ### 2. Fork Prevention | ||
|
|
||
| ``` | ||
| // The Suggest() function is not familiar to me, can you provide the Golang code location? |
Contributor
There was a problem hiding this comment.
In XDC the closest thing would be something like https://vscode.dev/github/XinFinOrg/XDPoSChain/blob/dev-upgrade/core/blockchain.go#L2036
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
src/Nethermind/Nethermind.Xdc/README.mdTypes of changes
What types of changes does your code introduce?
Testing
Requires testing
Documentation
Requires documentation update