Skip to content

chore: remove dead IsSyncing field and its assignment #9790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukaszRozmej merged 4 commits into from
Nov 26, 2025
Merged

chore: remove dead IsSyncing field and its assignment #9790

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eaa7791
chore: remove dead IsSyncing field and its assignment
ANtutov Nov 26, 2025
c1b5a24
Apply suggestion from @LukaszRozmej
LukaszRozmej Nov 26, 2025
4740739
Simplify result creation in SyncingSubscription
LukaszRozmej Nov 26, 2025
f4db1fe
Fix resource leak by using 'using' statement
LukaszRozmej Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 8 additions & 19 deletions src/Nethermind/Nethermind.JsonRpc/Modules/Subscribe/SyncingSubscription.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,6 @@ public SyncingSubscription(

private class SubscriptionSyncingResult
{
[JsonIgnore]
public bool? IsSyncing { get; set; }
public long? StartingBlock { get; set; }
public long? CurrentBlock { get; set; }
public long? HighestBlock { get; set; }
Expand All @@ -63,24 +61,15 @@ private void OnConditionsChange(object? sender, BlockEventArgs e)
if (_logger.IsTrace) _logger.Trace($"Syncing subscription {Id} changed syncing status from {_lastIsSyncing} to {isSyncing}");

_lastIsSyncing = isSyncing;
JsonRpcResult result;

if (isSyncing == false)
{
result = CreateSubscriptionMessage(isSyncing);
}
else
{
result = CreateSubscriptionMessage(new SubscriptionSyncingResult()
{
IsSyncing = syncingResult.IsSyncing,
StartingBlock = syncingResult.StartingBlock,
CurrentBlock = syncingResult.CurrentBlock,
HighestBlock = syncingResult.HighestBlock
});
}

using (result)
using (JsonRpcResult result = !isSyncing
? CreateSubscriptionMessage(false)
: CreateSubscriptionMessage(new SubscriptionSyncingResult()
{
StartingBlock = syncingResult.StartingBlock,
CurrentBlock = syncingResult.CurrentBlock,
HighestBlock = syncingResult.HighestBlock
}))
{
await JsonRpcDuplexClient.SendJsonRpcResult(result);
}
Expand Down