Skip to content

Better logs on invalid orphan #9641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukaszRozmej merged 2 commits into from
Nov 4, 2025
Merged

Better logs on invalid orphan #9641

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aea6624
Try fixing world wrong block
LukaszRozmej Nov 4, 2025
90f117a
not this, so keep validating Withdrawals
LukaszRozmej Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/Nethermind/Nethermind.Core/InvalidBlockHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@ namespace Nethermind.Core;

public static class InvalidBlockHelper
{
public static string GetMessage(Block? block, string reason)
{
return $"Rejected invalid block {block?.ToString(Block.Format.FullHashNumberAndExtraData)}, reason: {reason}";
}
public static string GetMessage(Block? block, string reason) =>
$"Rejected invalid block {block?.ToString(Block.Format.FullHashNumberAndExtraData)}, reason: {reason}";
}
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Merge.Plugin/Handlers/NewPayloadHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ public async Task<ResultWrapper<PayloadStatusV1>> HandleAsync(ExecutionPayload r
{
if (!_blockValidator.ValidateOrphanedBlock(block!, out string? error))
{
if (_logger.IsWarn) _logger.Warn(InvalidBlockHelper.GetMessage(block, "orphaned block is invalid"));
if (_logger.IsWarn) _logger.Warn(InvalidBlockHelper.GetMessage(block, $"orphaned block is invalid: {error}"));
return NewPayloadV1Result.Invalid(null, $"Invalid block without parent: {error}.");
}

Expand Down
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Optimism/OptimismBlockValidator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public override bool ValidateBodyAgainstHeader(BlockHeader header, BlockBody toB
}

protected override bool ValidateWithdrawals(Block block, IReleaseSpec spec, bool validateHashes, ref string? error) =>
ValidateWithdrawals(block.Header, block.Body, out error);
!validateHashes || ValidateWithdrawals(block.Header, block.Body, out error);

private bool ValidateWithdrawals(BlockHeader header, BlockBody body, out string? error)
{
Expand Down