Skip to content

feat: write AckMessage directly to IByteBuffer without temp array #9623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benaadams merged 1 commit into from
Nov 2, 2025
Merged

feat: write AckMessage directly to IByteBuffer without temp array #9623

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions src/Nethermind/Nethermind.Network/Rlpx/Handshake/AckMessageSerializer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,9 @@ public class AckMessageSerializer : IZeroMessageSerializer<AckMessage>
public void Serialize(IByteBuffer byteBuffer, AckMessage msg)
{
byteBuffer.EnsureWritable(TotalLength);
// TODO: find a way to now allocate this here
byte[] data = new byte[TotalLength];
Buffer.BlockCopy(msg.EphemeralPublicKey.Bytes, 0, data, EphemeralPublicKeyOffset, EphemeralPublicKeyLength);
Buffer.BlockCopy(msg.Nonce, 0, data, NonceOffset, NonceLength);
data[IsTokenUsedOffset] = msg.IsTokenUsed ? (byte)0x01 : (byte)0x00;
byteBuffer.WriteBytes(data);
byteBuffer.WriteBytes(msg.EphemeralPublicKey.Bytes);
byteBuffer.WriteBytes(msg.Nonce);
byteBuffer.WriteByte(msg.IsTokenUsed ? (byte)0x01 : (byte)0x00);
}

public AckMessage Deserialize(IByteBuffer msgBytes)
Expand Down