Skip to content

Remove redundant length==1 special-case in SliceWithZeroPadding #9566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukaszRozmej merged 1 commit into from
Oct 31, 2025
Merged

Remove redundant length==1 special-case in SliceWithZeroPadding #9566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions src/Nethermind/Nethermind.Evm/ByteArrayExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,15 +21,6 @@ private static ZeroPaddedSpan SliceWithZeroPadding(this ReadOnlySpan<byte> span,
return new ZeroPaddedSpan(default, length, padDirection);
}

if (length == 1)
{
// why do we return zero length here?
// it was passing all the tests like this...
// return bytes.Length == 0 ? new byte[0] : new[] {bytes[startIndex]};
return span.Length == 0 ? new ZeroPaddedSpan(default, 0, padDirection) : new ZeroPaddedSpan(span.Slice(startIndex, 1), 0, padDirection);
// return bytes.Length == 0 ? new ZeroPaddedSpan(default, 1) : new ZeroPaddedSpan(bytes.Slice(startIndex, 1), 0);
}

int copiedLength = Math.Min(span.Length - startIndex, length);
return new ZeroPaddedSpan(span.Slice(startIndex, copiedLength), length - copiedLength, padDirection);
}
Expand Down
Loading