Skip to content

Validate sizes and types #9564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smartprogrammer93 merged 1 commit into from
Oct 24, 2025
Merged

Validate sizes and types #9564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions src/Nethermind/Nethermind.TxPool/RetryCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ public RetryCache(ILogManager logManager, int timeoutMs = 2500, int requestingCa
_requestingResources.Set(item.ResourceId);
}

if (_logger.IsWarn) _logger.Warn($"Sending retry requests for {item.ResourceId} after timeout");
if (_logger.IsTrace) _logger.Trace($"Sending retry requests for {item.ResourceId} after timeout");


foreach (IMessageHandler<TMessage> retryHandler in requests)
Expand All @@ -62,7 +62,7 @@ public RetryCache(ILogManager logManager, int timeoutMs = 2500, int requestingCa
}
catch (Exception ex)
{
if (_logger.IsWarn) _logger.Error($"Failed to send retry request to {retryHandler} for {item.ResourceId}", ex);
if (_logger.IsTrace) _logger.Error($"Failed to send retry request to {retryHandler} for {item.ResourceId}", ex);
}
}
}
Expand All @@ -80,15 +80,15 @@ public AnnounceResult Announced(TResourceId resourceId, IMessageHandler<TMessage

_retryRequests.AddOrUpdate(resourceId, (resourceId) =>
{
if (_logger.IsWarn) _logger.Warn($"Announced {resourceId} by {retryHandler}: NEW");
if (_logger.IsTrace) _logger.Trace($"Announced {resourceId} by {retryHandler}: NEW");

_expiringQueue.Enqueue((resourceId, DateTimeOffset.UtcNow.AddMilliseconds(_timeoutMs)));
added = true;

return [];
}, (resourceId, dict) =>
{
if (_logger.IsWarn) _logger.Warn($"Announced {resourceId} by {retryHandler}: UPDATE");
if (_logger.IsTrace) _logger.Trace($"Announced {resourceId} by {retryHandler}: UPDATE");

dict.Add(retryHandler);
return dict;
Expand All @@ -97,14 +97,14 @@ public AnnounceResult Announced(TResourceId resourceId, IMessageHandler<TMessage
return added ? AnnounceResult.New : AnnounceResult.Enqueued;
}

if (_logger.IsWarn) _logger.Warn($"Announced {resourceId} by {retryHandler}, but a retry is in progress already, immidietly firing");
if (_logger.IsTrace) _logger.Trace($"Announced {resourceId} by {retryHandler}, but a retry is in progress already, immidietly firing");

return AnnounceResult.New;
}

public void Received(TResourceId resourceId)
{
if (_logger.IsWarn) _logger.Warn($"Received {resourceId}");
if (_logger.IsTrace) _logger.Trace($"Received {resourceId}");

_retryRequests.TryRemove(resourceId, out PooledSet<IMessageHandler<TMessage>>? _);
_requestingResources.Delete(resourceId);
Expand Down