Skip to content

Use trace instead of warn #9563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LukaszRozmej merged 2 commits into from
Oct 24, 2025
Merged

Use trace instead of warn #9563

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
202ae8a
use trace
deffrian Oct 24, 2025
00a5dd5
if
deffrian Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Nethermind/Nethermind.Network/P2P/ProtocolHandlers/ProtocolHandlerBase.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ protected T Deserialize<T>(IByteBuffer data) where T : P2PMessage
int originalReaderIndex = data.ReaderIndex;
T result = _serializer.Deserialize<T>(data);
if (data.IsReadable()) ThrowIncompleteDeserializationException(data, originalReaderIndex);
Logger.Warn($"{Counter} Got {typeof(T).Name}");
if (Logger.IsTrace) Logger.Trace($"{Counter} Got {typeof(T).Name}");

return result;
}
Expand All @@ -114,7 +114,7 @@ private static void ThrowIncompleteDeserializationException(IByteBuffer data, in
protected internal void Send<T>(T message) where T : P2PMessage
{
Interlocked.Increment(ref Counter);
Logger.Warn($"{Counter} Sending {typeof(T).Name}");
if (Logger.IsTrace) Logger.Trace($"{Counter} Sending {typeof(T).Name}");
if (NetworkDiagTracer.IsEnabled)
{
string messageString = message.ToString();
Expand Down