Skip to content

Xdc Pool for timeouts and votes #9521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cicr99 merged 5 commits into from
Oct 23, 2025
Merged

Xdc Pool for timeouts and votes #9521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d55c1e9
implement pool for timeouts and votes
cicr99 Oct 21, 2025
3720141
remove unnecessary array allocation
cicr99 Oct 22, 2025
2632581
Merge branch 'master' into feature/xdc-pool
ak88 Oct 23, 2025
f340887
Merge branch 'master' into feature/xdc-pool
ak88 Oct 23, 2025
75b3322
merged
ak88 Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Nethermind/Nethermind.Xdc/Types/Timeout.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,10 @@ namespace Nethermind.Xdc.Types;
public class Timeout(ulong round, Signature? signature, ulong gapNumber) : IXdcPoolItem
{
private readonly TimeoutDecoder _decoder = new();

public ulong Round { get; set; } = round;
public Signature? Signature { get; set; } = signature;
public ulong GapNumber { get; set; } = gapNumber;
public Address? Signer { get; set; }

public override string ToString() => $"{Round}:{GapNumber}";
public (ulong Round, Hash256 hash) PoolKey() => (Round, Keccak.Compute(_decoder.Encode(this, RlpBehaviors.ForSealing).Bytes));
}
2 changes: 1 addition & 1 deletion src/Nethermind/Nethermind.Xdc/XdcPool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public void EndRound(ulong round)
{
using var lockRelease = _lock.Acquire();
{
foreach (var key in _items.Keys.ToArray())
foreach (var key in _items.Keys)
{
if (key.Round <= round && _items.Remove(key, out ArrayPoolList<T> list))
{
Expand Down